[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43029884 LGTM. Thanks! I will take a look at #726 today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread ajtulloch
Github user ajtulloch commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43020578 @mengxr - thanks for the comments, I've updated with the fixes. Please also have a look at https://github.com/apache/spark/pull/726 which cleans up formatting, code dup

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43029934 Thanks. Merged this into master & branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43023787 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14949/ --- If your project

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43023786 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43020526 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/725#discussion_r12594596 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala --- @@ -69,6 +69,43 @@ class SVMSuite extends FunSuite with LocalSparkContex

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/725#discussion_r12594467 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala --- @@ -69,6 +69,43 @@ class SVMSuite extends FunSuite with LocalSparkContex

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-43020506 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-42981423 ah, I made this ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-13 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/725#discussion_r12594375 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/SVMSuite.scala --- @@ -69,6 +69,43 @@ class SVMSuite extends FunSuite with LocalSparkContex

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-42757678 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-11 Thread ajtulloch
GitHub user ajtulloch opened a pull request: https://github.com/apache/spark/pull/725 SPARK-1791 - SVM implementation does not use threshold parameter Summary: https://issues.apache.org/jira/browse/SPARK-1791 Simple fix, and backward compatible, since - anyone w

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-42758415 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14879/ --- If your project

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-42758411 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-1791 - SVM implementation does not use t...

2014-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/725#issuecomment-42757676 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha