[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43449385 @mateiz That's a good question. I browsed through the Hadoop 2.4.0 binary distribution, and it looks like none of the `hadoop-*` JAR files are 'assembly' JARs -- they all

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-17 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43429692 @srowen Hadoop does distribute binary artifacts that work without a dependency download, so it might be good to let them know about this. Thanks for taking a look at the

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/770 SPARK-1827. LICENSE and NOTICE files need a refresh to contain transitive dependency info LICENSE and NOTICE policy is explained here: http://www.apache.org/dev/licensing-howto.html

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43066220 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43066236 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43069220 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14976/ --- If your project

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43069219 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43105049 @srowen thanks a bunch for ton for looking through this. I'll go ahead and merge this and cut a new RC/ --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43117310 Hey @srowen - I noticed that hadoop and a bunch of the other Apache projects have like 3-4 things in the NOTICE file. Are those projects in violation of the letter of

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43117559 E.g. look at how few are mentioned in http://www.us.apache.org/dist/hadoop/common/hadoop-2.4.0/. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43117466 I was going to ask the same thing, from what I've seen in other projects. It probably doesn't hurt to keep all of these notices, especially if they're automatically

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/770#issuecomment-43127826 I think the difference is that Spark is distributing its dependencies too in the assembly, whereas I am not sure Hadoop et al. do more than distribute their own artifacts.

[GitHub] spark pull request: SPARK-1827. LICENSE and NOTICE files need a re...

2014-05-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is