Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-51220473
Yep, I was just waiting on a review. If you are good with it then I'll
commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-51234407
merged into master and branch-1.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-50695702
Jenkins, test this please. @tgravescs are you waiting for more feedback on
this? It seems pretty good to me!
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-50696010
QA tests have started for PR 1196. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17514/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-50699927
QA results for PR 1196:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14941021
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14941058
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-49051107
QA tests have started for PR 1196. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16683/consoleFull
---
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47341211
You can't determine the user unless some sort of authentication filter is
in place. the UI returns null in that case. You can't check acls against a
null user
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14291718
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14271724
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14272505
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1196#discussion_r14272616
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -169,18 +192,43 @@ private[spark] class SecurityManager(sparkConf:
SparkConf)
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47292171
Looks ok, aside from the minor semantic issue above. The comment below
scares me a little bit:
If the user is null it is assumed authentication isn't turned
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47014954
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47014974
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47020392
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16063/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1196#issuecomment-47020390
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
19 matches
Mail list logo