[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-07-09 Thread dbtsai
Github user dbtsai closed the pull request at: https://github.com/apache/spark/pull/1215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-07-09 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1215#issuecomment-48555878 @dbtsai As we discussed offline, this is an incompatible change, and it doesn't seem to be necessary. You can throw an exception in your implementation if you don't want t

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1215#discussion_r14223272 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/Gradient.scala --- @@ -37,7 +37,11 @@ abstract class Gradient extends Serializable {

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1215#issuecomment-47169836 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16124/ --- If your project

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1215#issuecomment-47169835 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1215#issuecomment-47166090 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1215#issuecomment-47166104 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

2014-06-25 Thread dbtsai
GitHub user dbtsai opened a pull request: https://github.com/apache/spark/pull/1215 SPARK-2281 [MLlib] Simplify the duplicate code in Gradient.scala The Gradient.compute which returns new tuple of (gradient: Vector, loss: Double) can be constructed by in-place version of Gradient.co