[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-30 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-50698688 OK, that would be a more comprehensive solution, then I will close this one --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-30 Thread CodingCat
Github user CodingCat closed the pull request at: https://github.com/apache/spark/pull/1331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-30 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-50691209 @CodingCat what if instead of this we just don't ship the local spark home to the cluster? There is really no reason to do that... I spoke with @andrewor14 about it toda

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-22 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-49744276 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-15 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-49094964 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-11 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48802333 I think using $SPARK_HOME instead of $FWDIR may bring some errors, e.g. if SPARK_HOME in remote cluster does not exist in the local machine (where the driver r

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-09 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48514775 Just to be sure, this will only change the exported SPARK_HOME variable, which may be used to actually start executors or some such. However, we will keep using `$FWDIR`

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-09 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48456435 @aarondav how about the current one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48428746 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16445/ --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48428744 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48426960 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48426942 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48425215 no luck with Jenkins recently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48425130 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16444/ --- If your project is set up for it, you can

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48425129 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48423029 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48423019 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48380362 sure, I will append the modification this evening, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48380200 This change seems quite reasonable, though we should probably do this in other places as well, like run-example and pyspark. --- If your project is set up for it, you c

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48378386 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16411/ --- If your project

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48378385 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48372313 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1331#issuecomment-48372331 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2404: don't overwrite SPARK_HOME when it...

2014-07-08 Thread CodingCat
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/1331 SPARK-2404: don't overwrite SPARK_HOME when it is set In spark-class and spark-submit, the SPARK_HOME is set to the present working directory, causing the value of already defined SPARK_HOME being