Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49576941
@pwendell The reason I did this is, if you compile a file A.scala with
contents
```scala
@SomeAnnotation
object A
```
it will produce two class
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49579128
Also according to current code flow we don't check methods if we spot an
annotation on a class. I can remove this restriction if you are okay with it.
---
If your
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/1463
SPARK-2497 Exclude companion classes, with their corresponding objects.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark-1
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49302217
QA tests have started for PR 1463. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16777/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49314286
QA results for PR 1463:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1463#issuecomment-49341909
@ScrapCodes could you explain a bit more how this fixes SPARK-2497. If I
look at the original false-positive the issue reported was not with a companion
class. It was
