[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-09 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1657#discussion_r17330807 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -105,6 +105,8 @@ private[spark] class SparkSubmitArguments(args: S

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-09 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-55035709 nit: could you make the pr title refer to what's actually changing? The current title sounds very generic, while the change is specific to a single config option. --- If

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54700643 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19881/consoleFull) for PR 1657 at commit [`d8a5a12`](https://github.com/a

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54698946 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19881/consoleFull) for PR 1657 at commit [`d8a5a12`](https://github.com/ap

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54697430 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54694545 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54391216 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19708/consoleFull) for PR 1657 at commit [`d8a5a12`](https://github.com/a

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54384109 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19708/consoleFull) for PR 1657 at commit [`d8a5a12`](https://github.com/ap

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-09-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-54383437 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-08-01 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-50922542 This makes sense to me. However, we should also document it and mention that it only currently works for YARN. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-08-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-50919882 I think currently `spark.executor.instances` is only used internally. However, it does seem useful here to expose this as a proper SparkConf value. @sryza what do you th

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1657#issuecomment-50594217 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: SPARK-2641: Fixing how spark arguments are loa...

2014-07-30 Thread kjsingh
GitHub user kjsingh opened a pull request: https://github.com/apache/spark/pull/1657 SPARK-2641: Fixing how spark arguments are loaded from properties file You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjsingh/spark branch-1.0