[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2015-01-15 Thread javadba
Github user javadba closed the pull request at: https://github.com/apache/spark/pull/1586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-68331226 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-68331223 QA results for PR 1586:- This patch FAILED unit tests.For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24880/consol

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-68328503 QA tests have started for PR 1586. This patch DID NOT merge cleanly! View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24880/consoleFull

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-67422217 Mind closing this manually? Our script seems to be missing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-17 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-67383303 OK Michael thanks for the update. 2014-12-17 11:21 GMT-08:00 Michael Armbrust : > > Hey @javadba , thanks for all the work on

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-12-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-67377013 Hey @javadba, thanks for all the work on this, especially the time figuring out the surprisingly complicated semantics for this function. Also, sorry for the delay with

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51643002 QA results for PR 1586:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):case class Length(child: Ex

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51640101 @marmbrusI am fine with delays on this - I just was unclear as to whether there some expectation on action on my part.Overall this is a minor enhancement but it h

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51633885 QA tests have started for PR 1586. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18209/consoleFull --- If

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51633297 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51633288 Sorry for the delay. We are a little swamped with the 1.1 release. I will trigger Jenkins. If we are still having issues with the SQL parser its probably okay to leav

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-08 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51614247 I have been waiting here for @ueshin and @marmbrus to decide on next steps. Please be clear what are the next steps at this point. --- If your project is set up for it,

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-05 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51179894 @javadba, @marmbrus I saw the case of SOF sometimes, it was not with @javadba's sequence, though. I can't identify the exact reason now, but I guess this is not re

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51152075 @javadba Thanks for detail. Let me replay the sequence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51149151 @ueshin I have git clone'd to a completely new area, and I reverted my last commit. git clone https://github.com/javadba/spark.git strlen2

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51146419 @ueshinI repeatably verified that simply changing "OCTET_LEN" to "OCTET_LENGTH" ended up causing SOF. By "repeatably" I mean: Set the 'constant' val O

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51145793 Hi @javadba, I tested `org.apache.spark.sql.SQLQuerySuite` and `org.apache.spark.sql.hive.execution.HiveQuerySuite` locally, and they worked fine even if I reverted the la

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51143772 QA results for PR 1586:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):case class Length(child: Ex

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51138818 QA tests have started for PR 1586. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17902/consoleFull --- If

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51138518 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-04 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51065193 Hi, For some reason the CORE module testing has ballooned in overall testing time: it took over 7.5 hours to run. There was one timeout error out of 736 tests - and

[GitHub] spark pull request: SPARK-2686 Add Length and OctetLen support to ...

2014-08-03 Thread javadba
Github user javadba commented on the pull request: https://github.com/apache/spark/pull/1586#issuecomment-51020150 The rename change was committed/pushed and the most germane tests pass. I am re-running full regression. One thing I have noticed already: the flume-sink external proje