Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-56571173
Thanks, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-56376900
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20654/consoleFull)
for PR 2403 at commit
[`5a9e706`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-56368082
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20654/consoleFull)
for PR 2403 at commit
[`5a9e706`](https://github.com/ap
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-56015430
I guess we will have to exclude those in MimaExcludes.scala. If this
happens too often, then *may be* we can ignore toString for all classes
possible.
---
If your pr
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55978495
Yeah I think this is an actual problem, see
https://issues.scala-lang.org/browse/SI-3664. Maybe we should just go with
Durations for simplicity.
---
If your project is s
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55978382
Actually it may also be the case that the object doesn't work quite the way
the default companion object for a case class should. Can you double check that
stuff like `Dur
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55978195
Yeah, these seem like false positives. @ScrapCodes can you take a look and
suggest how to update the MIMA rules if these are indeed false positives?
---
If your project i
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55864499
I'm not sure what to make of the MIMA errors:
* the type hierarchy of object org.apache.spark.streaming.Duration has
changed in new version. Missing types {scala.r
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55831137
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20430/consoleFull)
for PR 2403 at commit
[`bda301c`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55825726
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20430/consoleFull)
for PR 2403 at commit
[`bda301c`](https://github.com/ap
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55825501
@mateiz Ah of course. I overlooked the obvious somehow. I'm looking at why
MIMA binary checks fail to see if it has a point or not now.
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55825251
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20426/consoleFull)
for PR 2403 at commit
[`7dde949`](https://github.com/a
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55820256
Ah, sure, I think we can just skip milliseconds in that case.
For the scalastyle checks, why not use spaces around the operators instead?
They should work in that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55817871
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20426/consoleFull)
for PR 2403 at commit
[`7dde949`](https://github.com/ap
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55777417
@mateiz Will do. There's one catch. Since `Duration` has an accessor named
`milliseconds`, and has a private accessor called `millis` from the
constructor, I can't create
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55688595
@srowen I think that in addition to these, it would be nice to have static
constructor methods, such as Duration.seconds(500) and Duration.minutes(10).
Mind adding those t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55675754
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20357/consoleFull)
for PR 2403 at commit
[`4dee32e`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2403#issuecomment-55675667
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20357/consoleFull)
for PR 2403 at commit
[`4dee32e`](https://github.com/ap
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/2403
SPARK-2745 [STREAMING] Add Java friendly methods to Duration class
@tdas is this what you had in mind for this JIRA? I saw this one and
thought it would be easy to take care of, and helpful as I use
20 matches
Mail list logo
