Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53242451
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19136/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53238173
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19136/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/ap
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53237810
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53220264
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19130/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53218619
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19130/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53218469
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53218467
LGTM. Also spoke to @pwendell offline that its cool to add flume version
(that is version of libraries used in external projects) in root pom.xml. Test
this once more and m
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16639309
--- Diff: pom.xml ---
@@ -125,6 +125,7 @@
2.4.1
${hadoop.version}
0.94.6
+1.4.0
--- End diff --
Yes, lets not bump
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53149251
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19105/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53148099
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19105/consoleFull)
for PR 1726 at commit
[`a46e2c6`](https://github.com/ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53140142
@srowen I left the other fixes to the pom.xml for you in this PR. Once
https://github.com/apache/spark/pull/2101 is merged, can you updated this PR. I
will merge it before 1
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53140011
@pwendell @harishreedharan @srowen There is a better fix for fixing the
maven build alone. There is no reason to depend on spark-streaming tests. So I
eliminated that depend
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53137854
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53136441
Looks like there is no real way to have the test jar depend on the non-test
jar. The only way to do this is to do the "preferred way" in this page:
http://maven.a
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626770
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626690
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53135372
Yes, the test code depends on test code from streaming - not on non-test
code (directly - the test code may depend on it - isn't it maven's job to
figure out tran
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626631
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--- End dif
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53135223
How do you explain the compile failure then? The test code does plainly
depend on the non-test streaming module. It depends on `TestSuiteBase` from
streaming which d
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626588
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-53134963
Actually, the Spark Sink test code only depends on the test jar. The test
jar seems to depend on the main jar. I am not sure why the sink's pom must also
pull in
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626471
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--- End dif
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16626447
--- Diff: pom.xml ---
@@ -125,6 +125,7 @@
2.4.1
${hadoop.version}
0.94.6
+1.4.0
--- End diff --
Maybe so; I want
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16625779
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16625739
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--- End dif
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16625685
--- Diff: pom.xml ---
@@ -125,6 +125,7 @@
2.4.1
${hadoop.version}
0.94.6
+1.4.0
--- End diff --
We can
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16625663
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,15 @@
- org.scala-lang
- scala-library
--
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-52951761
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19059/consoleFull)
for PR 1726 at commit
[`138523b`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-52944285
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19059/consoleFull)
for PR 1726 at commit
[`138523b`](https://github.com/ap
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-52944078
@witgo Yes I see the same issue now after a rebase. I added your extra
dependency, rebased, and it works. Let's see what Jenkins says.
---
If your project is set up for i
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/1726#discussion_r16541517
--- Diff: external/flume-sink/pom.xml ---
@@ -65,12 +66,9 @@
- org.scala-lang
- scala-library
-
-
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-52922473
I tested, but compile failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-52906646
@pwendell Could you take a look? @tdas approves and I think this may
resolve https://github.com/apache/spark/pull/2075 too
---
If your project is set up for it, you can
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-51412557
@pwendell I think this is a good set of changes. Can you take a quick look.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-51319235
QA results for PR 1726:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1726#issuecomment-51314361
QA tests have started for PR 1726. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18017/consoleFull
---
If
37 matches
Mail list logo
