[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-17 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55910777 looks good. I tested it on hadoop 0.23 and it works also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55784185 @tgravescs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-14 Thread chesterxgchen
Github user chesterxgchen commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55545571 Reformatted based on Andrew's comment #2204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55545608 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20314/consoleFull) for PR 2204 at commit

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55547575 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20314/consoleFull) for PR 2204 at commit

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-54996816 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55000338 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20046/consoleFull) for PR 2204 at commit

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55007803 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20046/consoleFull) for PR 2204 at commit

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread chesterxgchen
Github user chesterxgchen commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-55013602 The unit test failed *sql/test:test* I run it locally, with the same configuration, the test passed. the changes is for yarn unit test, it doesn't

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r17331761 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends FunSuite

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-09 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r17331783 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends FunSuite

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-54694372 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-03 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r17032605 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends FunSuite

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-03 Thread chesterxgchen
Github user chesterxgchen commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r17048232 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-01 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r16945967 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends FunSuite

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-09-01 Thread chesterxgchen
Github user chesterxgchen commented on a diff in the pull request: https://github.com/apache/spark/pull/2204#discussion_r16964789 --- Diff: yarn/common/src/test/scala/org/apache/spark/deploy/yarn/ClientBaseSuite.scala --- @@ -232,6 +233,15 @@ class ClientBaseSuite extends

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-08-29 Thread chesterxgchen
GitHub user chesterxgchen opened a pull request: https://github.com/apache/spark/pull/2204 SPARK-3177 (on Master Branch) The JIRA and PR was original created for branch-1.1, and move to master branch now. Chester The Issue is due to that yarn-alpha and yarn have

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-53916073 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-3177 (on Master Branch)

2014-08-29 Thread chesterxgchen
Github user chesterxgchen commented on the pull request: https://github.com/apache/spark/pull/2204#issuecomment-53916231 I have tested against 2.0.5-alpha, 2.0.6-alpha (yarn-alpha) and 2.3.0-cdh5.0.0 (yarn-stable) all yarn-alpha/test and yarn-stable/test are passed. --- If