[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-03 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54303443 This failure (in `SparkSubmitSuite`) appears unrelated to my patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54303022 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19659/consoleFull) for PR 2220 at commit [`3b3e205`](https://github.com/a

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54289812 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19659/consoleFull) for PR 2220 at commit [`3b3e205`](https://github.com/ap

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54695034 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19845/consoleFull) for PR 2220 at commit [`3b3e205`](https://github.com/ap

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54699188 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19845/consoleFull)** after a configured wait of `120m`. --- If your project i

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54916080 Thanks for cleaning this up! Since this passed tests before I'm going to merge to master. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread willb
GitHub user willb opened a pull request: https://github.com/apache/spark/pull/2220 SPARK-3329: [SQL] Don't depend on Hive SET pair ordering. This fixes some possible spurious test failures in `HiveQuerySuite` by comparing sets of key-value pairs as sets, rather than as lists. You

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread concretevitamin
Github user concretevitamin commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-53995569 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-53995653 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19543/consoleFull) for PR 2220 at commit [`36ff52a`](https://github.com/ap

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread concretevitamin
Github user concretevitamin commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-53995880 Ah, so this problem *was* fixed in PR #1514, but it seems like this [PR](https://github.com/apache/spark/commit/a7a9d14479ea6421513a962ff0f45cb969368bab#diff-48)

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-53996991 Thanks, @concretevitamin! I'll close this one then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-08-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-53998959 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19543/consoleFull) for PR 2220 at commit [`36ff52a`](https://github.com/a

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread willb
Github user willb commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54165469 @concretevitamin I cherry-picked @aarondav's fix (and added a very simple fix to handle cases that it didn't). --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54165982 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19590/consoleFull) for PR 2220 at commit [`6525d8e`](https://github.com/ap

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54182324 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19590/consoleFull) for PR 2220 at commit [`6525d8e`](https://github.com/a

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/2220#discussion_r17030555 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -520,62 +520,69 @@ class HiveQuerySuite extends HiveCompar

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2014-09-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-54249254 Hey @willb, thanks for looking into / fixing this! Minor pattern matching suggestion only. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: SPARK-3329: [SQL] Don't depend on Hive SET pai...

2015-02-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2220#issuecomment-73394623 @marmbrus @liancheng Can we backport this into `branch-1.1` (1.1.2)? I've been observing a lot of flakiness in the "HiveQuerySuite.SET commands semantics for a HieCont