Github user patmcdonough closed the pull request at:
https://github.com/apache/spark/pull/2447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user patmcdonough commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-93545909
Thanks for following up on this @srowen - I didn't even realize it's still
open.
I'll close this out in favor of somebody issuing a new patch as I'm not in
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-93383384
@patmcdonough are you in a position to follow up on the comments above? I'm
wondering if this is alive or not or whether it should be closed.
---
If your project is set u
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-75160191
Yeah I think it's still worth doing just to enforce consistent APIs across
python and Scala. Merge conflicts may be a little annoying but they shouldn't
stop us from b
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-75157364
FWIW I think:
- needs a rebase
- scaladoc should be consistent with others in `RDD.scala` -- no shell
example
- `JavaRDD` needs this even more since I thin
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-75156001
The changes here look fine. @pwendell @markhamstra any additional thoughts?
This PR hasn't had much activity for a while.
---
If your project is set up for it, you ca
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57529771
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21144/consoleFull)
for PR 2447 at commit
[`afc4e09`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57529782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57517283
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21144/consoleFull)
for PR 2447 at commit
[`afc4e09`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57516676
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57492030
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-57490224
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56217543
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20577/consoleFull)
for PR 2447 at commit
[`afc4e09`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56208954
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20577/consoleFull)
for PR 2447 at commit
[`afc4e09`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56208207
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user patmcdonough commented on a diff in the pull request:
https://github.com/apache/spark/pull/2447#discussion_r17794069
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -208,6 +208,23 @@ abstract class RDD[T: ClassTag](
}
/**
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56081115
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20540/consoleFull)
for PR 2447 at commit
[`de966fd`](https://github.com/a
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2447#discussion_r17745104
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -208,6 +208,23 @@ abstract class RDD[T: ClassTag](
}
/**
+ * Get
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/2447#discussion_r17741897
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -208,6 +208,23 @@ abstract class RDD[T: ClassTag](
}
/**
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56072266
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20540/consoleFull)
for PR 2447 at commit
[`de966fd`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56071597
LGTM pending a minor comment and tests. Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2447#discussion_r17740875
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -208,6 +208,23 @@ abstract class RDD[T: ClassTag](
}
/**
+ * Get
Github user patmcdonough commented on the pull request:
https://github.com/apache/spark/pull/2447#issuecomment-56061006
thanks for catching that @laserson! Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
23 matches
Mail list logo
