Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67529975
Looks good, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67525739
[Test build #24593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24593/consoleFull)
for PR 3471 at commit
[`20b9887`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67525753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67512174
this looks good. kicked jenkins to run again since last run was while ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67512322
[Test build #24593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24593/consoleFull)
for PR 3471 at commit
[`20b9887`](https://githu
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-67512122
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66404718
@andrewor14, makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66402995
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66402988
[Test build #24293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24293/consoleFull)
for PR 3471 at commit
[`20b9887`](https://gith
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66397955
Hey @sryza unfortunately this will have to block until we figure out in
#3490 what the appropriate naming scheme for AM configs to use collectively.
Otherwise we might
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66397719
[Test build #24293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24293/consoleFull)
for PR 3471 at commit
[`20b9887`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66397588
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66386289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66384598
Updated patch uses the old property to set the wait time if the new one
isn't set.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-66358381
LGTM, but do we need to add backward compatibility? This patch seems to get
rid of the old config altogether and Spark will silently ignore the setting if
an old appli
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65938199
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65813151
changes look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65687902
[Test build #24142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24142/consoleFull)
for PR 3471 at commit
[`ce6dff2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65687913
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65675709
[Test build #24142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24142/consoleFull)
for PR 3471 at commit
[`ce6dff2`](https://githu
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-65675297
Thanks for the feedback, Tom. Updated the patch to reflect your and Wang
Tao's comments.
I left out adding MS to the config name because it's inconsistent with all
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3471#discussion_r21309688
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -353,13 +355,13 @@ private[spark] class ApplicationMaster(
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3471#discussion_r21309571
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -353,13 +355,13 @@ private[spark] class ApplicationMaster(
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3471#discussion_r21309453
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -329,8 +329,10 @@ private[spark] class ApplicationMaster(a
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3471#discussion_r21309273
--- Diff: docs/running-on-yarn.md ---
@@ -22,10 +22,12 @@ Most of the configs are the same for Spark on YARN as
for other deployment modes
Proper
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-64653209
Why we need a `val waitTime = 100`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-64521938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-64521933
[Test build #23878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23878/consoleFull)
for PR 3471 at commit
[`12eb0cd`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-64516503
[Test build #23878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23878/consoleFull)
for PR 3471 at commit
[`12eb0cd`](https://githu
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3471#issuecomment-64516335
@tgravescs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
GitHub user sryza opened a pull request:
https://github.com/apache/spark/pull/3471
SPARK-3779. yarn spark.yarn.applicationMaster.waitTries config should be...
... changed to a time period
You can merge this pull request into a Git repository by running:
$ git pull https://githu
32 matches
Mail list logo
