Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139798279
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139736176
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139736177
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139735880
[Test build #42366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42366/console)
for PR 6297 at commit
[`6351fc8`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139721982
[Test build #42366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42366/consoleFull)
for PR 6297 at commit
[`6351fc8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139721907
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-139721904
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r39227939
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -295,6 +295,60 @@ object functions {
def min(columnName: String): Column =
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r39227597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -249,6 +249,155 @@ case class Min(child: Expr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138036449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138036447
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138036422
[Test build #42062 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42062/console)
for PR 6297 at commit
[`6035648`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138015991
[Test build #42062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42062/consoleFull)
for PR 6297 at commit
[`6035648`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138015843
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-138015838
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137802508
R style check failure is caused by commit of SPARK-8951
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137796647
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137796648
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137796643
[Test build #42006 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42006/console)
for PR 6297 at commit
[`a81d0fc`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137796024
[Test build #42006 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42006/consoleFull)
for PR 6297 at commit
[`a81d0fc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137794776
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-137794798
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135852765
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135852763
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135852699
[Test build #41748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41748/console)
for PR 6297 at commit
[`0902ceb`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135820655
[Test build #41748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41748/consoleFull)
for PR 6297 at commit
[`0902ceb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135817886
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135817978
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135693660
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135693657
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135693383
[Test build #41732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41732/console)
for PR 6297 at commit
[`f4c725c`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135657532
[Test build #41732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41732/consoleFull)
for PR 6297 at commit
[`f4c725c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135657176
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135657157
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135655316
[Test build #41730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41730/console)
for PR 6297 at commit
[`25425ac`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135655318
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135655321
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135654368
[Test build #41730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41730/consoleFull)
for PR 6297 at commit
[`25425ac`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135650454
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-135650541
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-125978916
@JihongMA Will you get time to implement the function based on the new API?
It will be good if we can merge it before the 1.5 deadline for new features
(end of this month)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124724353
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124724335
[Test build #38399 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38399/console)
for PR 6297 at commit
[`87fd2dc`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124722519
[Test build #38399 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38399/consoleFull)
for PR 6297 at commit
[`87fd2dc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124720733
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124720700
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-124720386
Please don't test it yet, need to make change to accomodate API change
introduced by other JIRA.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121797696
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121797646
[Test build #37428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37428/console)
for PR 6297 at commit
[`a4cfe74`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121785283
[Test build #37428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37428/consoleFull)
for PR 6297 at commit
[`a4cfe74`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121784799
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121784886
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121773151
[Test build #37411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37411/console)
for PR 6297 at commit
[`43fb84f`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121773207
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121757829
[Test build #37411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37411/consoleFull)
for PR 6297 at commit
[`43fb84f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121757701
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121757668
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121727475
[Test build #37398 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37398/console)
for PR 6297 at commit
[`1ca4373`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121727545
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r34717145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -761,3 +761,216 @@ case class LastFunction(expr: Exp
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r34714426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -761,3 +761,216 @@ case class LastFunction(expr: Expres
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121707474
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121707803
[Test build #37398 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37398/consoleFull)
for PR 6297 at commit
[`1ca4373`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121707510
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r34706204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -761,3 +761,216 @@ case class LastFunction(expr: Exp
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r34627743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -761,3 +761,216 @@ case class LastFunction(expr: Expres
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121405267
@JihongMA Can you change your test to use fixed precision decimal types (or
double type) for now? We need a fundamental fix of our decimal types. I think
we should not blo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121399547
[Test build #37267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37267/console)
for PR 6297 at commit
[`c752054`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121399587
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121394398
[Test build #37267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37267/consoleFull)
for PR 6297 at commit
[`c752054`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121392628
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121392716
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121392552
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121391850
#7212 has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121385974
I will merge https://github.com/apache/spark/pull/7212 soon. So this one
will be unblocked.
---
If your project is set up for it, you can reply to this email and have you
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121326693
Thanks for testing out the code changes. the test failure is caused by
SPARK-8800 and waiting for the fix to be merged.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121323391
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121323347
[Test build #37243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37243/console)
for PR 6297 at commit
[`c752054`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121318863
[Test build #37243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37243/consoleFull)
for PR 6297 at commit
[`c752054`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121318114
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121318157
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-121072605
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-117799636
the issue introduced by SPARK-8359 was fixed via SPARK-8677, but causing
accuracy issue over Decimal data, that issue need to be fixed first.
---
If your project is
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-117268484
sorry, the code is not ready to be merged as I noticed one more issue with
Decimal type, fixing it and will let you know once I am ready plus code style
fix.
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116959293
[Test build #36089 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36089/console)
for PR 6297 at commit
[`e46c964`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116959304
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116957360
[Test build #36089 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36089/consoleFull)
for PR 6297 at commit
[`e46c964`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116955519
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116955534
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-116955337
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-115977926
while preparing the code change to address review comments. I noticed the
fix for SPARK-8359 is causing issue with decimal type, I put a comment there on
that JIRA and
Github user JihongMA commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-115422767
I will incorporate the comments shortly. Thank you Michael for reviewing
the code.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user sujkh85 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33313527
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -372,7 +372,7 @@ class DataFrameSuite extends QueryTest {
val desc
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33313504
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -372,7 +372,7 @@ class DataFrameSuite extends QueryTest {
val des
Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33313463
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -372,7 +372,7 @@ class DataFrameSuite extends QueryTest {
val des
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/6297#issuecomment-114325358
Thanks for working on this! I made some style comments, mostly from stuff
you can find here:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33001725
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -372,7 +372,7 @@ class DataFrameSuite extends QueryTest {
val des
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33001587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -746,3 +746,219 @@ case class LastFunction(expr: Exp
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6297#discussion_r33001595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -746,3 +746,219 @@ case class LastFunction(expr: Exp
1 - 100 of 107 matches
Mail list logo
