Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117904528
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117856892
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117856830
[Test build #36316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36316/console)
for PR 7167 at commit
[`f4b9bc8`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117848985
[Test build #36316 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36316/consoleFull)
for PR 7167 at commit
[`f4b9bc8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117848599
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117848593
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117848104
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117848092
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user Rosstin commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117841525
@mengxr @holdenk Alright, I restored the multiline comments conforming to
the 100-character rule
---
If your project is set up for it, you can reply to this email and h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117837038
Let's keep the line width within 100. As @holdenk mentioned, we can copy &
paste a paragraph of code to Scala and ipython easily. I also tried RStudio,
which takes multil
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117826411
For copypasteing in Scala mode :paste mode makes the multi-line copy/past
work well (although requires remembering that + ctrl-d)
---
If your project is set up for it,
Github user Rosstin commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117820353
@mengxr Would it be desirable to un-multiline the LOC in the file's
comments? Or should these remain multiline to follow style? (What I mean is,
the lines are long enoug
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7167#issuecomment-117820196
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user Rosstin opened a pull request:
https://github.com/apache/spark/pull/7167
[SPARK-8660] [MLLib] removed > symbols from comments in
LogisticRegressionSuite.scala for ease of copypaste
'>' symbols removed from comments in LogisticRegressionSuite.scala, for
ease of copypaste
Github user Rosstin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33719147
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite exten
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33714575
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7096#discussion_r33714571
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -211,22 +211,22 @@ class LogisticRegressionSuite extend
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7096
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116856496
Thanks - merging this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116856432
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116856329
[Test build #36027 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36027/console)
for PR 7096 at commit
[`242aedd`](https://github.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116845502
Thanks - LGTM. We can merge this once Jenkins comes back happy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user Rosstin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116838453
@rxin Of course, my bad
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116835524
Thanks - one more thing. Can you change Spark-8660 to [SPARK-8660] ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116834309
[Test build #36027 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36027/consoleFull)
for PR 7096 at commit
[`242aedd`](https://gith
Github user Rosstin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116834065
@rxin done, hope that's not too long
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116832823
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116832780
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116830856
@Rosstin can you update the pull request title to make it more descriptive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116830752
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7096#issuecomment-116830453
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user Rosstin opened a pull request:
https://github.com/apache/spark/pull/7096
Spark-8660
Converted JavaDoc style comments in
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
to regular multiline comments, to make copy-pasting R commands e
33 matches
Mail list logo
