[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread tylerprete
Github user tylerprete commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145983509 # Transitive dependencies ## json4s 3.2.10 ![screenshot 2015-10-06 13 03

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread tylerprete
Github user tylerprete commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145991347 I created a JIRA for this: https://issues.apache.org/jira/browse/SPARK-10958 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145985465 The only problem I anticipate here is the different version of Jackson. Spark is on ~2.4 and I recall that trying to use an app with 2.5+ causes problems, which leads me

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145987604 I'm pretty sure that I've run into problems when bumping the jackson-databind version in the past, so we'll have to be careful here. --- If your project is set up

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-146000776 @tylerprete update the title too -- have a look at the contributing link above. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-146006529 I mean the title of this PR, to link it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread tylerprete
Github user tylerprete commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-146004959 @srowen I updated it... seems a bit better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145775734 Hm, does 3.3.0 require Scala 2.11? or pull in a different version? there's a compile problem here. This probably needs an analysis of the diff in the dependency:tree

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread tylerprete
Github user tylerprete commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145934402 @JoshRosen I believe there some minor version bumps. I'll run dependency graph on both a bit later and try to get more exact changes. I assume you're talking to me

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-06 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145928134 @srowen, there's definitely a 2.10 version of that artifact published to Maven: http://mvnrepository.com/artifact/org.json4s/json4s-jackson_2.10/3.3.0 Maybe

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread tylerprete
GitHub user tylerprete opened a pull request: https://github.com/apache/spark/pull/8992 Use json4s 3.3.0. DefaultFormats is now serializable. Having serializable Formats makes json4s much nicer to work with in Spark. This seems like a worthwhile upgrade, especially since it's

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145713116 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145724621 (Whoops, meant to cc @srowen ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145724524 Are there any changes in this library's transitive dependency graph? /cc @srown @pwendell for dependency changes / bumps. --- If your project is set up for

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145724773 Do you mind filing a JIRA for this change? See https://issues.apache.org/jira/browse/SPARK and

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145724395 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145726007 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145726049 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145726925 [Test build #43269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43269/consoleFull) for PR 8992 at commit

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145727434 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145727424 [Test build #43269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43269/console) for PR 8992 at commit

[GitHub] spark pull request: Use json4s 3.3.0. DefaultFormats is now serial...

2015-10-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8992#issuecomment-145727432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your