[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-10-09 Thread npanj
Github user npanj commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-58576241 Sorry was out of loop for a while... closing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-10-09 Thread npanj
Github user npanj closed the pull request at: https://github.com/apache/spark/pull/901 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-09-11 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-55363783 @npanj Mind closing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-54694692 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-09-02 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-54219480 @pwendell @npanj @rxin This isn't mergeable at the moment because it doesn't parse the edge attributes correctly. Since it's [difficult](https://github.com/apache/spark/

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-09-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-54100620 @ankurdave @rxin could you guys come to a decision on this one way or the other? Also @npanj mind adding `[GRAPHX]` to the title here? Right now this is getting sorted wi

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-02 Thread npanj
Github user npanj commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44902699 @ankurdave - thanks for explanation about parsable and use of implicit.(I will try to implement it) - about storage level of the vertex attributes, yes I was trying

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44794906 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44794907 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15340/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44794861 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44794866 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44793789 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44793790 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15337/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44793764 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44793756 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44784833 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44784834 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15329/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44784794 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44784800 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44746122 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15320/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44746121 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44746090 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44746088 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44746040 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-31 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44745827 Unlike Python (but like Java), Scala doesn't use asInstanceOf for arbitrary type conversions. In this case, it won't work to do `"123".asInstanceOf[Int]`, because Scala

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread npanj
Github user npanj commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44478613 @rxin - Allowing arbitrary data types sounds like a good idea. I actually tried to to do something like: -- def edgeListFile[@specialized(Long, Int, Double) ED: Class

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3996 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15258/ --- If your project is set up for it, you can r

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3995 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3759 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3781 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3723 Upon further look, it might be better if we allow users to define the way to parse the 3rd argument to allow arbitrary data types. What do you think? --- If your project is

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3365 This is definitely a good change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-3373 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/901#issuecomment-44378287 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: Use optional third argument as edge attribute.

2014-05-28 Thread npanj
GitHub user npanj opened a pull request: https://github.com/apache/spark/pull/901 Use optional third argument as edge attribute. This is probably easiest way to include edge weight. Unless you guys have been thinking about some other ways? I also wanted to add one more argument for