Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-70466677
Let's close this issue pending an update from @holdenk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-63606245
@tdas if people are doing major dependency re-writes of Spark to replace
it's logging subsystem, IMO, they should be willing to tolerate a runtime error
if they try to c
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60666140
@tdas If we switch to a different logging library it would just be a matter
of calling the new log libraries change log level function (and possibly
translating some stri
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60328324
Great! But how does this interact in situations where the downstream
applications have explicitly removed Log4j from their path because they use
other logging libraries (the
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60322408
@holdenk Could you add some examples about how the logging levels should
be? All list all the valid names in docstring.
@tdas We could use this in the Streaming ex
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60131449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60131442
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22039/consoleFull)
for PR 2433 at commit
[`3429353`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60120436
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22039/consoleFull)
for PR 2433 at commit
[`3429353`](https://github.com/ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60115919
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60115914
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22038/consoleFull)
for PR 2433 at commit
[`e6ae26a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-60115048
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22038/consoleFull)
for PR 2433 at commit
[`e6ae26a`](https://github.com/ap
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56780109
Sure I will do that tomorrow :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56776540
Hey @holdenk forgot to mention - can you add this in Java and Python also?
Guessing this will be really useful for people working on the Spark shell.
---
If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56609697
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20732/consoleFull)
for PR 2433 at commit
[`03ed4f9`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56609700
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20732/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56604522
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20732/consoleFull)
for PR 2433 at commit
[`03ed4f9`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56585257
Minor comments, otherwise looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2433#discussion_r17937235
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -232,6 +232,12 @@ class SparkContext(config: SparkConf) extends Logging {
/**
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2433#discussion_r17937194
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1453,6 +1453,14 @@ private[spark] object Utils extends Logging {
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56478099
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20687/consoleFull)
for PR 2433 at commit
[`cdb3bfc`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56478104
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20687/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-56475233
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20687/consoleFull)
for PR 2433 at commit
[`cdb3bfc`](https://github.com/ap
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55966808
yeah, that works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55964974
Sounds good, how about I have the spark context do the conversion and call
the utils method?
---
If your project is set up for it, you can reply to this email and have y
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55964698
One case where this could be useful is in the Spark shell:
```
scala> sc.setLoggingLevel("WARN")
```
---
If your project is set up for it, you can reply
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55964616
Is the idea here for this to be called by spark users or by spark internal
components? If the former, this won't be visible because it's in a private
object. It could be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55949708
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20477/consoleFull)
for PR 2433 at commit
[`44d6577`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2433#issuecomment-55942860
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20477/consoleFull)
for PR 2433 at commit
[`44d6577`](https://github.com/ap
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/2433
add a util method for changing the log level while running
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark
SPARK-3444-provide-an-
30 matches
Mail list logo
