[GitHub] spark pull request: improve the readability of SparkContext.scala

2014-04-15 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/414 improve the readability of SparkContext.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SparkContext Alternatively you can revie

[GitHub] spark pull request: improve the readability of SparkContext.scala

2014-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/414#issuecomment-40483532 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: improve the readability of SparkContext.scala

2014-04-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/414#issuecomment-40668420 Thanks for submitting this. I see what you are trying to accomplish (by putting inits into a start method). However, I'm not sure if it actually improves readability when we

[GitHub] spark pull request: improve the readability of SparkContext.scala

2014-04-16 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/414#issuecomment-40675137 From the side of the life cycle for component, only stop method is incomplete, and the initialize code , start code written separately is better --- If your project is set

[GitHub] spark pull request: improve the readability of SparkContext.scala

2014-05-07 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable