[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95174344 The changes look OK; Jenkins will double-check. I am still not sure what you mean about SPARK-7056, which is about the streaming write-ahead log. Typo? --- If your

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95182753 Normally we do make JIRAs for changes unless it would be pretty redundant with a simple, self-evident pull request. This is borderline. But SPARK-7056 is a real,

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95216642 [Test build #30756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30756/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95216688 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95184603 It makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95160977 [Test build #30756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30756/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95164649 I think that's fine, since this is an example, though this is not related to SPARK-7056? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95175701 It means nothing, first I intend to update the pom.xml file and give it a new name [spark-7056], while it is a part of this pull request. --- If your project is set up

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95169296 SPARK-7056 is just a new commit, after updating the pom.xml file, the CMSHasherImplicits compatibility problem can be solved as well. --- If your project is set up for

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
GitHub user caikehe opened a pull request: https://github.com/apache/spark/pull/5629 update the deprecated CountMinSketchMonoid function to TopPctCMS function http://twitter.github.io/algebird/index.html#com.twitter.algebird.legacy.CountMinSketchMonoid$ The CountMinSketchMonoid

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95067917 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95116415 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95111876 We're on 0.8.1, so if it compiles, that seems OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95111721 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95116156 [Test build #30749 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30749/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95116410 [Test build #30749 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30749/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95146105 @caikehe It failed style tests actually: ``` Scalastyle checks failed at following occurrences: [error]

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95145475 package orange.fr.scalaTest import com.twitter.algebird._ import com.twitter.algebird.CMSHasherImplicits._ import org.apache.spark.SparkConf

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95146954 Yes, or just add a space before the comment. Now it should work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95147233 [Test build #30754 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30754/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95148383 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95148379 [Test build #30754 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30754/consoleFull) for PR 5629 at commit

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95151867 Click the results above -- this does not compile. ``` [error]

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95151650 @AmplabJenkins, I checked the build results, access rights to CI server needed? While it is mergeable. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: update the deprecated CountMinSketchMonoid fun...

2015-04-22 Thread caikehe
Github user caikehe commented on the pull request: https://github.com/apache/spark/pull/5629#issuecomment-95155509 http://twitter.github.io/algebird/#com.twitter.algebird.CMSHasherImplicits$ http://mvnrepository.com/artifact/com.twitter/algebird-core_2.10 On the pom.xml file,