[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r35960 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(

[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r16289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(

[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r222144135 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(

[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r221972056 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(

[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r221966919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(

[GitHub] spark pull request #10989: [SPARK-12798] [SQL] generated BroadcastHashJoin

2018-10-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10989#discussion_r221961271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -117,6 +120,87 @@ case class BroadcastHashJoin(