Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65821620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +88,42 @@ package object expressions {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65821593
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +88,42 @@ package object expressions {
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65821238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +88,42 @@ package object expressions {
/**
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65821217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +88,42 @@ package object expressions {
/**
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65821205
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
/**
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65811458
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
/**
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65809321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
---
@@ -26,13 +26,6 @@ object AttributeMap {
def
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65808923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65808887
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65808880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65808854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65804344
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
/**
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65804276
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
/**
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65797603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
/**
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65795007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -296,7 +296,7 @@ abstract class QueryPlan[PlanType <:
Qu
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65794996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
---
@@ -86,11 +86,31 @@ package object expressions {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65794395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -296,7 +296,7 @@ abstract class QueryPlan[PlanType <:
Qu
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65793015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -84,17 +84,27 @@ object BindReferences extends
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65792855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -84,17 +84,27 @@ object BindReferences extends
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13505#discussion_r65792692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -84,17 +84,27 @@ object BindReferences extends
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/13505
[SPARK-15764][SQL] Replace N^2 loop in BindReferences
BindReferences contains a n^2 loop which causes performance issues when
operating over large schemas: to determine the ordinal of an attribut
22 matches
Mail list logo
