Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67968854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,28 @@ object ExpressionEncoder {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67965175
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,28 @@ object ExpressionEncoder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67933216
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,25 @@ object ExpressionEncoder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67932528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,28 @@ object ExpressionEncoder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67932028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,28 @@ object ExpressionEncoder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67931868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,28 @@ object ExpressionEncoder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67912070
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -830,6 +830,13 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67887470
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -830,6 +830,13 @@ class DatasetSuite extends QueryTest with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67880034
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -830,6 +830,13 @@ class DatasetSuite extends QueryTest with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13807#discussion_r67879774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -110,16 +110,25 @@ object ExpressionEncoder {
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/13807
[SPARK-16097][SQL] Encoders.tuple should handle null object correctly
## What changes were proposed in this pull request?
Although the top level input object can not be null, but when we
12 matches
Mail list logo