GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/14259
[SPARK-16622][SQL] Fix NullPointerException when the returned value of the
called method in Invoke is null
## What changes were proposed in this pull request?
Currently we don't check the v
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71313676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -147,12 +158,12 @@ case class Invoke(
}
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71313787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -134,10 +134,21 @@ case class Invoke(
va
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71330808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -134,10 +134,21 @@ case class Invoke(
v
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71331553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -147,12 +158,12 @@ case class Invoke(
}
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71371459
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -147,12 +158,12 @@ case class Invoke(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71496316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -166,11 +185,11 @@ case class Invoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71638351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -166,11 +185,11 @@ case class Invoke(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71669886
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -314,4 +343,14 @@ class DatasetAggregatorSuite extends QueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71676959
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -314,4 +343,14 @@ class DatasetAggregatorSuite extends QueryTest wi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71825205
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -314,4 +343,14 @@ class DatasetAggregatorSuite extends QueryTest wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71825821
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -314,4 +343,14 @@ class DatasetAggregatorSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71880582
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14259#discussion_r71885571
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
15 matches
Mail list logo
