[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r72099637 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala --- @@ -927,6 +927,14 @@ class LogicalPlanToSQLSuite exten

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r72099113 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala --- @@ -927,6 +927,14 @@ class LogicalPlanToSQLSuite extends SQLBui

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r72039701 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -512,8 +512,12 @@ class SQLBuilder(logicalPlan: LogicalPlan) ex

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r72038927 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala --- @@ -512,8 +512,12 @@ class SQLBuilder(logicalPlan: LogicalPlan) exten

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r71976751 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/SQLBuilderSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14307#discussion_r71976388 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/SQLBuilderSuite.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request #14307: [SPARK-16672][SQL] SQLBuilder should not raise ex...

2016-07-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14307 [SPARK-16672][SQL] SQLBuilder should not raise exceptions on EXISTS queries ## What changes were proposed in this pull request? Currently, `SQLBuilder` raises `empty.reduceLeft` excep