[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72047779 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable( overr

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72010784 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable( overr

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009811 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -20,10 +20,11 @@ package org.apache.spark.sql.sources im

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009802 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -110,6 +110,25 @@ case class CatalogTablePartition(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r72009804 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -173,8 +190,18 @@ case class CatalogTable( overr

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71996213 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -365,9 +365,6 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71989869 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -498,23 +498,19 @@ case class DescribeTableCommand(table: Tab

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71982334 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -498,23 +498,19 @@ case class DescribeTableCommand(table: Ta

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71982259 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -365,9 +365,6 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71982245 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -365,9 +365,6 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14331#discussion_r71982187 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -764,10 +761,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #14331: [SPARK-16691][SQL] move BucketSpec to catalyst mo...

2016-07-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/14331 [SPARK-16691][SQL] move BucketSpec to catalyst module and use it in CatalogTable ## What changes were proposed in this pull request? It's weird that we have `BucketSpec` to abstract buck