Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74198336
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74197901
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74197622
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74197135
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74196093
--- Diff: sql/core/src/test/resources/sql-tests/inputs/number-format.sql ---
@@ -0,0 +1,13 @@
+-- Verifies how we parse numbers
+
+-- parse as ints
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74195995
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74195916
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74195419
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74194929
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74194064
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74191334
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190988
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190989
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190929
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190946
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190732
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190305
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189795
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189661
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189487
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189403
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189204
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73817418
--- Diff:
sql/core/src/test/resources/sql-tests/results/number-format.sql.out ---
@@ -0,0 +1,50 @@
+-- Automatically generated by org.apache.spark.sql.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73816313
--- Diff: dev/.rat-excludes ---
@@ -99,4 +99,5 @@ spark-deps-.*
.*tsv
org.apache.spark.scheduler.ExternalClusterManager
.*\.sql
+.*\.sql\
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73774227
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73486454
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73484246
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73473216
--- Diff: dev/.rat-excludes ---
@@ -99,4 +99,5 @@ spark-deps-.*
.*tsv
org.apache.spark.scheduler.ExternalClusterManager
.*\.sql
+.*\.sql\
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73281256
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73281270
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73281221
--- Diff: sql/core/src/test/resources/sql-tests/inputs/number-format.sql ---
@@ -0,0 +1,13 @@
+-- Verifies how we parse numbers
+
+-- parse as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73280922
--- Diff: sql/core/src/test/resources/sql-tests/inputs/number-format.sql ---
@@ -0,0 +1,13 @@
+-- Verifies how we parse numbers
+
+-- parse as i
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73280876
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73280720
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73272864
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73272873
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r73272687
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
GitHub user petermaxlee opened a pull request:
https://github.com/apache/spark/pull/14472
[SPARK-16866][SQL] Infrastructure for file-based SQL end-to-end tests
## What changes were proposed in this pull request?
This patch introduces SQLQueryTestSuite, which is a basic framework
39 matches
Mail list logo
