[GitHub] spark pull request #14538: [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDi...

2016-08-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14538#discussion_r73972010 --- Diff: python/pyspark/sql/functions.py --- @@ -112,11 +112,8 @@ def _(): 'sinh': 'Computes the hyperbolic sine of the given value.',

[GitHub] spark pull request #14538: [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDi...

2016-08-08 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14538#discussion_r73970614 --- Diff: python/pyspark/sql/functions.py --- @@ -112,11 +112,8 @@ def _(): 'sinh': 'Computes the hyperbolic sine of the given value.',

[GitHub] spark pull request #14538: [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDi...

2016-08-08 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14538#discussion_r73966599 --- Diff: python/pyspark/sql/functions.py --- @@ -112,11 +112,8 @@ def _(): 'sinh': 'Computes the hyperbolic sine of the given value.', 'tan':

[GitHub] spark pull request #14538: [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDi...

2016-08-08 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14538 [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDistinct, toDegrees and toRadians according to FunctionRegistry as well. ## What changes were proposed in this pull request? It seems `ap