Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86470657
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -417,11 +429,12 @@ private[spark] class HiveExternalCatalog(conf:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86469470
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -95,8 +95,11 @@ private[spark] class HiveExternalCatalog(conf:
Sp
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86471858
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -537,22 +559,11 @@ private[spark] class HiveExternalCatalog(conf:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86469682
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -255,6 +267,12 @@ private[spark] class HiveExternalCatalog(conf:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86471149
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -475,18 +490,27 @@ private[spark] class HiveExternalCatalog(conf:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86472353
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -620,7 +667,9 @@ private[spark] class HiveExternalCatalog(conf:
S
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r86470287
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -372,10 +386,8 @@ private[spark] class HiveExternalCatalog(con
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r84817845
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -446,29 +452,46 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r84817656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -373,7 +373,7 @@ case class InsertIntoTab
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78666218
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -93,8 +92,11 @@ private[spark] class HiveExternalCatalog(conf:
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78659438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -373,7 +373,7 @@ case class InsertInto
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78641530
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -93,8 +92,11 @@ private[spark] class HiveExternalCatalog(conf
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78494405
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -93,8 +92,11 @@ private[spark] class HiveExternalCatalog(conf:
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78474805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
@@ -245,4 +245,28 @@ object DataType {
case (fromDataType, to
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78129508
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -169,7 +169,10 @@ case class InsertIntoHiveTable(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78124662
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -169,7 +169,10 @@ case class InsertIntoHiveTable(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78120149
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -169,7 +169,10 @@ case class InsertIntoHiveTable(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78114385
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -446,29 +449,46 @@ private[spark] class HiveExternalCatalog(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78113922
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -446,29 +449,46 @@ private[spark] class HiveExternalCatalog(co
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78106864
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -446,29 +449,46 @@ private[spark] class HiveExternalCatalog(c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r78104317
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -408,7 +411,9 @@ private[spark] class HiveExternalCatalog(con
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r77636703
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -413,29 +415,48 @@ private[spark] class HiveExternalCatalog(cl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r76709732
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -413,29 +415,48 @@ private[spark] class HiveExternalCatalog(c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r76703496
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -413,29 +415,48 @@ private[spark] class HiveExternalCatalog(c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r76702974
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -413,29 +415,48 @@ private[spark] class HiveExternalCatalog(c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r76699427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -373,7 +373,7 @@ case class InsertIn
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14750#discussion_r76697635
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -166,15 +165,19 @@ private[spark] class HiveExternalCatalog(c
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/14750
[SPARK-17183][SQL] put hive serde table schema to table properties like
data source table
## What changes were proposed in this pull request?
For data source tables, we will put its tabl
28 matches
Mail list logo
