Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80072725
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80072011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80070804
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80069407
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80063167
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r80066262
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,22 +200,17 @@ abstract class ProbabilisticClassif
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79864108
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -48,13 +48,28 @@ class ProbabilisticClassifierSui
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79853709
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -469,10 +469,10 @@ def getStandardization(self):
class HasThresholds(Params):
"""
-
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79851244
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -50,9 +50,9 @@ private[shared] object SharedParamsCodeGen {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79852470
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -469,10 +469,10 @@ def getStandardization(self):
class HasThresholds(Params):
"""
-
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79806820
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -48,13 +48,31 @@ class ProbabilisticClassifierSui
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79806638
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -48,13 +48,31 @@ class ProbabilisticClassifierSui
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79805782
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79635467
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class ProbabilisticClassifi
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79635015
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class ProbabilisticClassifi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79631445
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class ProbabilisticClassifi
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79630399
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79628242
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -200,26 +200,9 @@ abstract class ProbabilisticClassifi
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79583415
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -176,10 +176,26 @@ private[ml] trait HasThreshold extends Params {
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79556533
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79555920
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79412702
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15149#discussion_r79409985
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ProbabilisticClassifierSuite.scala
---
@@ -56,6 +56,21 @@ class ProbabilisticClassifierSuit
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/15149
[SPARK-17057] [ML] ProbabilisticClassifierModels' thresholds should be > 0
and sum < 1 to match randomForest cutoff
## What changes were proposed in this pull request?
Match ProbabilisticCl
25 matches
Mail list logo
