Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r82490916
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,52 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81283911
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81283611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81283082
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81282421
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81278191
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81275138
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -19,9 +19,10 @@ package
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81274703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -697,4 +697,27 @@ object JdbcUtils extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81274640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -697,4 +697,27 @@ object JdbcUtils extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81147277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -697,4 +697,27 @@ object JdbcUtils extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81147460
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -697,4 +697,27 @@ object JdbcUtils extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r81124219
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -697,4 +697,27 @@ object JdbcUtils extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80957517
--- Diff: docs/sql-programming-guide.md ---
@@ -1058,7 +1059,21 @@ the Data Sources API. The following options are
supported:
The JDBC fetch
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80957168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -61,3 +61,12 @@ class JDBCOptions(
//
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80845890
--- Diff: docs/sql-programming-guide.md ---
@@ -1058,7 +1059,21 @@ the Data Sources API. The following options are
supported:
The JDBC fetch
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80845726
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,48 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80845381
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,48 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80844741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,48 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80739029
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,52 @@ class
Github user JustinPihony commented on a diff in the pull request:
https://github.com/apache/spark/pull/15263#discussion_r80738565
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -50,67 +51,52 @@ class
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/15263
[SPARK-14525][SQL][FOLLOWUP] Clean up JdbcRelationProvider
## What changes were proposed in this pull request?
This PR proposes cleaning up the confusing part in `createRelation` as
22 matches
Mail list logo
