GitHub user erenavsarogullari opened a pull request: https://github.com/apache/spark/pull/15604
Add Pool usage policies test coverage for FIFO & FAIR Schedulers ## What changes were proposed in this pull request? The following FIFO & FAIR Schedulers Pool usage cases need to have unit test coverage : - FIFO Scheduler just uses **root pool** so even if `spark.scheduler.pool` property is set, related pool is not created and `TaskSetManagers` are added to **root pool**. - FAIR Scheduler uses `default pool` when `spark.scheduler.pool` property is not set. This can be happened when - `Properties` object is **null** - `Properties` object is **empty**(`new Properties()`) - It points **default pool**(`spark.scheduler.pool=default`). - FAIR Scheduler creates a **new pool** with **default values** when `spark.scheduler.pool` property points **non-existent** pool. This can be happened when **scheduler allocation file** is not set or it does not contain related pool. ## How was this patch tested? New Unit tests are added. You can merge this pull request into a Git repository by running: $ git pull https://github.com/erenavsarogullari/spark SPARK-18066 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15604.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15604 ---- commit 9e588cf33ea3a99b384399a7b444ee7fb9df82d5 Author: erenavsarogullari <erenavsarogull...@gmail.com> Date: 2016-10-23T20:37:26Z Add Pool usage policies test coverage for FIFO & FAIR Schedulers ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org