Github user mariusvniekerk closed the pull request at:
https://github.com/apache/spark/pull/15666
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143838425
--- Diff: python/pyspark/tests.py ---
@@ -435,6 +436,19 @@ def test_add_file_locally(self):
with open(download_path) as test_file:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143018955
--- Diff: python/pyspark/context.py ---
@@ -863,6 +863,21 @@ def addPyFile(self, path):
import importlib
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143019603
--- Diff: python/pyspark/tests.py ---
@@ -435,6 +436,19 @@ def test_add_file_locally(self):
with open(download_path) as test_file:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143015274
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143014933
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,32 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143018036
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143015101
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143017669
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1845,6 +1859,21 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r143017806
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1845,6 +1859,21 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r14301
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r122578282
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r122578275
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r106786961
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r106781948
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r105839398
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r105723828
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r105723482
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104908469
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104592654
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104593039
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104592294
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104592782
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104592268
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104527246
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1800,17 +1800,39 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104527000
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1800,17 +1800,39 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104523062
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104522704
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104486665
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104433603
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1842,6 +1864,14 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104432976
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104433213
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -308,6 +308,36 @@ class SparkContextSuite extends SparkFunSuite with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104432962
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104431249
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104429730
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104408350
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104360211
--- Diff: R/pkg/inst/tests/testthat/test_context.R ---
@@ -167,6 +167,18 @@ test_that("spark.lapply should perform simple
transforms", {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104358500
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104357841
--- Diff: R/pkg/R/context.R ---
@@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r104358056
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -168,6 +168,27 @@ private[spark] object TestUtils {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r100177099
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1802,19 +1802,34 @@ class SparkContext(config: SparkConf) extends
Logging
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r100176735
--- Diff: python/pyspark/context.py ---
@@ -836,6 +836,17 @@ def addPyFile(self, path):
import importlib
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r100176188
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1802,19 +1802,34 @@ class SparkContext(config: SparkConf) extends
Logging
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r98948530
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r98949834
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r98950178
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1802,19 +1802,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r98948623
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1802,19 +1802,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r93730314
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -164,6 +164,27 @@ private[spark] object TestUtils {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r93729928
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -164,6 +164,27 @@ private[spark] object TestUtils {
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r93338899
--- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala ---
@@ -164,6 +164,27 @@ private[spark] object TestUtils {
Github user mariusvniekerk closed the pull request at:
https://github.com/apache/spark/pull/15666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user mariusvniekerk reopened a pull request:
https://github.com/apache/spark/pull/15666
[SPARK-11421] [Core][Python][R] Added ability for addJar to augment the
current classloader
## What changes were proposed in this pull request?
Adds a flag to sc.addJar to add
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85865112
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user mariusvniekerk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85833766
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85830311
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85829905
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1700,19 +1700,34 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15666#discussion_r85829640
--- Diff: R/pkg/R/context.R ---
@@ -290,6 +290,33 @@ spark.addFile <- function(path, recursive = FALSE) {
invisible(callJMethod(sc, "addFile",
GitHub user mariusvniekerk opened a pull request:
https://github.com/apache/spark/pull/15666
[SPARK-11421] [Core][Python][R] Added ability for addJar to augment the
current classloader
## What changes were proposed in this pull request?
Adds a flag to sc.addJar to add the
58 matches
Mail list logo
