[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86919161 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -115,9 +115,22 @@ object RewriteDisti

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86731806 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -115,9 +115,19 @@ object RewriteDist

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86731715 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -115,9 +115,19 @@ object RewriteDist

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86730659 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -23,7 +23,7 @@ import org.apache.sp

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86731982 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -134,10 +144,10 @@ object RewriteDis

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86756665 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -115,9 +115,21 @@ object RewriteDist

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86731142 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala --- @@ -150,6 +150,24 @@ class HiveUDFSuite extends QueryTest wi

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86730984 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -261,9 +275,9 @@ object RewriteDisti

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-11-07 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15668#discussion_r86731012 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala --- @@ -237,8 +251,8 @@ object RewriteDisti

[GitHub] spark pull request #15668: [SPARK-18137][SQL]Fix RewriteDistinctAggregates U...

2016-10-27 Thread windpiger
GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/15668 [SPARK-18137][SQL]Fix RewriteDistinctAggregates UnresolvedException w… ## What changes were proposed in this pull request? In RewriteDistinctAggregates rewrite funtion,after the UDAF's