Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891844
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -18,15 +18,15 @@
package org.apache.spark.ml.util
import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891724
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -1810,52 +1810,23 @@ class LogisticRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891824
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -157,50 +162,26 @@ class NaiveBayesSuite extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891797
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -25,31 +25,36 @@ import
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891833
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -47,6 +49,11 @@ class LinearRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891849
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -182,34 +182,18 @@ object MLTestingUtils extends SparkFunSuite {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891892
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,59 @@ object MLTestingUtils extends SparkFunSuite {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93891859
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -182,34 +182,18 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93763421
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -47,6 +49,11 @@ class LinearRegressionSuite
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93760292
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -182,34 +182,18 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93761461
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -182,34 +182,18 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93765361
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -25,31 +25,36 @@ import
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93762729
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -1810,52 +1810,23 @@ class
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93762341
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,59 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93765319
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -157,50 +162,26 @@ class NaiveBayesSuite extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93759584
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -18,15 +18,15 @@
package org.apache.spark.ml.util
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93481050
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93481882
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -47,6 +49,11 @@ class LinearRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93481080
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93481030
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93459365
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93420640
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93174061
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93172081
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93172224
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93171343
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93172654
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15721#discussion_r93172182
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -224,4 +208,139 @@ object MLTestingUtils extends SparkFunSuite {
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/15721
[SPARK-17772][ML][TEST] Add test functions for ML sample weights
## What changes were proposed in this pull request?
More and more ML algos are accepting sample weights, and they have been
30 matches
Mail list logo
