Github user Yunni closed the pull request at:
https://github.com/apache/spark/pull/15800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87528327
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -76,7 +72,19 @@ class MinHashModel private[ml] (
@Since("2.1.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87429950
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -76,7 +72,19 @@ class MinHashModel private[ml] (
@Since("2.1.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87335796
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -76,7 +72,19 @@ class MinHashModel private[ml] (
@Since("2.1.0")
Github user Yunni commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87298552
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -32,13 +32,7 @@ import org.apache.spark.sql.types.StructType
* :: Experime
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87245481
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -32,13 +32,7 @@ import org.apache.spark.sql.types.StructType
* :: Expe
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15800#discussion_r87174202
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHash.scala ---
@@ -32,13 +32,7 @@ import org.apache.spark.sql.types.StructType
* :: Experim
GitHub user Yunni opened a pull request:
https://github.com/apache/spark/pull/15800
[SPARK-18334] MinHash should use binary hash distance
## What changes were proposed in this pull request?
MinHash currently is using the same `hashDistance` function as
RandomProjection. This doe
