[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88581282 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLogSuite.scala --- @@ -0,0 +1,34 @@ +/* + * Licensed

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88581369 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -245,4 +284,25 @@ object CompactibleFileStr

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88580974 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -330,34 +331,51 @@ trait StreamTest extends QueryTest with SharedSQ

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88534136 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -245,4 +284,25 @@ object CompactibleFileStr

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88363586 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread tcondie
Github user tcondie commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88362276 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread tcondie
Github user tcondie commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88359775 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88352568 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88353628 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -161,7 +161,8 @@ trait StreamTest extends QueryTest with SharedSQLC

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88135983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSourceLog.scala --- @@ -38,8 +38,9 @@ class FileStreamSourceLog(

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88352982 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88353713 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -161,7 +161,8 @@ trait StreamTest extends QueryTest with SharedSQLC

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88354703 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88357129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88353911 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -330,14 +331,17 @@ trait StreamTest extends QueryTest with SharedSQ

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88353490 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -896,32 +898,35 @@ class FileStreamSourceSuite extends

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88114440 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88354869 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class CompactibleF

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-14 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r87941243 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class Compactible

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-14 Thread uncleGen
Github user uncleGen commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r87936909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -63,7 +63,60 @@ abstract class Compactible