Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15975
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r90183049
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -209,6 +209,16 @@ class JDBCSuite extends SparkFunSuite
conn.cl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r90098792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -76,9 +76,6 @@ class JDBCOptions(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89986253
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -76,9 +76,6 @@ class JDBCOptions(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89956695
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -209,6 +209,14 @@ class JDBCSuite extends SparkFunSuite
conn.c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89956633
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,13 +667,13 @@ object JdbcUtils extends Logg
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89956606
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -76,9 +76,6 @@ class JDBCOptions(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89946424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -76,9 +76,6 @@ class JDBCOptions(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89946224
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -209,6 +209,14 @@ class JDBCSuite extends SparkFunSuite
conn.cl
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89945683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -667,13 +667,13 @@ object JdbcUtils extends Loggi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89844825
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
numPa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89722356
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
numPar
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89693478
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:
S
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89684437
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:
Sp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89683214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:
Sp
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89445082
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -137,7 +137,8 @@ private[sql] case class JDBC
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89445068
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -159,7 +159,11 @@ class DataFrameReader private[sql](sparkSession:
Sp
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89190756
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
numPa
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89190321
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
numPa
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89181212
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
nu
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89087942
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -137,7 +137,8 @@ private[sql] case class JDBCRela
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89086596
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -159,7 +159,11 @@ class DataFrameReader private[sql](sparkSession:
SparkS
22 matches
Mail list logo
