Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157589
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -53,7 +53,23 @@ import org.apache.spark.storage.StorageLevel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157587
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -143,7 +143,18 @@ private[regression] trait
Gene
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125157502
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -421,6 +435,18 @@ object LinearRegression extends
DefaultPar
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125155063
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -53,7 +53,23 @@ import org.apache.spark.storage.StorageLevel
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r125155049
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -75,17 +78,13 @@ private[classification] t
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r124730326
--- Diff: python/pyspark/ml/classification.py ---
@@ -1327,8 +1327,6 @@ class MultilayerPerceptronClassifier(JavaEstimator,
HasFeaturesCol, HasLabelCol,
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r124170473
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -167,6 +168,8 @@ private[shared] object SharedParamsC
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r124166126
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -80,7 +80,7 @@ private[shared] object SharedParamsCod
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r123982677
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -97,6 +97,7 @@ private[shared] object SharedParamsCodeG
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r12398
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -80,7 +80,7 @@ private[shared] object SharedParamsCodeG
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r123982863
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -167,6 +168,8 @@ private[shared] object SharedParamsCod
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r94382823
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -101,7 +100,7 @@ private[classification]
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r94382491
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -421,6 +435,18 @@ object LinearRegression extends
DefaultPa
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r94380454
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -101,7 +100,7 @@ private[classification] trait
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16028#discussion_r94380581
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -421,6 +435,18 @@ object LinearRegression extends
DefaultParamsRe
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/16028
[SPARK-18518][ML] HasSolver supports override
## What changes were proposed in this pull request?
1, make param support non-final with `finalFields` option
2, generate `HasSolver` with
17 matches
Mail list logo
