[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91831031 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -180,35 +214,28 @@ abstract class StatisticsCollectionTestBas

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91830908 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -180,35 +214,28 @@ abstract class StatisticsCollectionTestBase ex

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91830853 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -180,35 +214,28 @@ abstract class StatisticsCollectionTestBase ext

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91830643 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -133,6 +133,79 @@ class StatisticsCollectionSuite extends Statis

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829574 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -213,7 +214,8 @@ object ColumnStat extends Logging {

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829511 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -133,6 +133,79 @@ class StatisticsCollectionSuite extends Statist

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829428 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -133,6 +133,79 @@ class StatisticsCollectionSuite extends Statist

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829432 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -133,6 +133,79 @@ class StatisticsCollectionSuite extends Statist

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829403 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -213,7 +214,8 @@ object ColumnStat extends Logging {

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16243#discussion_r91829332 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -133,6 +133,79 @@ class StatisticsCollectionSuite extends Statist

[GitHub] spark pull request #16243: [SPARK-18815] [SQL] Fix NPE when collecting colum...

2016-12-09 Thread wzhfy
GitHub user wzhfy opened a pull request: https://github.com/apache/spark/pull/16243 [SPARK-18815] [SQL] Fix NPE when collecting column stats for string/binary column having only null values ## What changes were proposed in this pull request? During column stats collection,