Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r106794245
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2909,6 +2910,30 @@ test_that("Collect on DataFrame when NAs exists at
the top of a
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r106789593
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2909,6 +2910,30 @@ test_that("Collect on DataFrame when NAs exists at
the top of a timestamp
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r106359526
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105565957
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105565947
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105562562
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105548957
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a timestamp
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105546348
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545762
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545724
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545712
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545530
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a timestamp
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545521
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r105545556
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at
the top of a timestamp
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r93351538
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -104,6 +104,12 @@ class SparkHadoopUtil extends Logging {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r93176308
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -104,6 +104,12 @@ class SparkHadoopUtil extends Logging {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r92984064
--- Diff: R/pkg/R/sparkR.R ---
@@ -381,6 +381,10 @@ sparkR.session <- function(
deployMode <- sparkConfigMap[["spark.submit.deployMode"]]
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r92955799
--- Diff: R/pkg/R/sparkR.R ---
@@ -381,6 +381,10 @@ sparkR.session <- function(
deployMode <- sparkConfigMap[["spark.submit.deployMode"]]
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r92955787
--- Diff: R/pkg/R/sparkR.R ---
@@ -381,6 +381,10 @@ sparkR.session <- function(
deployMode <- sparkConfigMap[["spark.submit.deployMode"]]
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r92953159
--- Diff: core/src/main/scala/org/apache/spark/api/r/RRDD.scala ---
@@ -127,6 +127,13 @@ private[r] object RRDD {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16330#discussion_r92953125
--- Diff: R/pkg/inst/tests/testthat/test_aFirstTest.R ---
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/16330
[SPARK-18817][SPARKR][SQL] change derby log output and metastore to temp dir
## What changes were proposed in this pull request?
Passes R `tempdir()` (this is the R session temp dir,
23 matches
Mail list logo
