[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16360#discussion_r93508333 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -219,7 +221,13 @@ final class DataStreamWriter[T] private[sq

[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16360#discussion_r93507397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalOutputModes.scala --- @@ -15,7 +15,7 @@ * limitations under the License.

[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-21 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16360#discussion_r93509028 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala --- @@ -219,7 +221,13 @@ final class DataStreamWriter[T] private[sq

[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-20 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/16360#discussion_r93353173 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala --- @@ -180,11 +181,41 @@ case class StateStoreSaveExec(

[GitHub] spark pull request #16360: [SPARK-18234][SS] Made update mode public

2016-12-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/16360#discussion_r93350564 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala --- @@ -180,11 +181,41 @@ case class StateStoreSaveExec(