[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-07-31 Thread bravo-zhang
Github user bravo-zhang commented on a diff in the pull request: https://github.com/apache/spark/pull/16365#discussion_r130432806 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-07-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16365#discussion_r130261853 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -184,14 +184,17 @@ class DataTypeSuite extends SparkFunSuite

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-07-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16365#discussion_r130261821 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-07-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16365#discussion_r130261747 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2017-06-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16365#discussion_r121590984 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {

[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

2016-12-20 Thread bravo-zhang
GitHub user bravo-zhang opened a pull request: https://github.com/apache/spark/pull/16365 [SPARK-18950][SQL] Report conflicting fields when merging two StructTypes ## What changes were proposed in this pull request? Currently, StructType.merge() only reports data types of co