Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16587#discussion_r96158395
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -278,7 +277,7 @@ abstract class ExternalCata
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16587#discussion_r96158356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -186,6 +186,11 @@ class InMemoryCatalog(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16587#discussion_r96155690
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1692,20 +1678,27 @@ class DDLSuite extends QueryTest wit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16587#discussion_r96145383
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -758,15 +758,17 @@ class DDLSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16587#discussion_r96145363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -370,22 +370,6 @@ trait CheckAnalysis extends Pre
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/16587
[SPARK-19229] [SQL] Disallow Creating Hive Source Tables when Hive Support
is Not Enabled
### What changes were proposed in this pull request?
It is weird to create Hive source tables when u
