Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102887155
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -794,6 +795,7 @@ EXPLAIN: 'EXPLAIN';
FORMAT: 'FORMAT';
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102775882
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -794,6 +795,7 @@ EXPLAIN: 'EXPLAIN';
FORMAT:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102647596
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -794,6 +795,7 @@ EXPLAIN: 'EXPLAIN';
FORMAT: 'FORMAT';
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102560014
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102410793
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102409892
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -282,7 +282,8 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102399167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102398658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -282,7 +282,8 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102398371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102138925
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102138379
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102137730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -92,7 +92,8 @@ case class ExecutedCommandExec(cmd:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102137661
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -282,7 +282,8 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102137390
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -197,20 +197,32 @@ class QueryExecution(val sparkSession:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r102137142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +57,29 @@ case class Statistics(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97482084
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +56,32 @@ case class Statistics(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97481455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +56,32 @@ case class Statistics(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97478978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -54,11 +56,32 @@ case class Statistics(
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97217477
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97216973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97216860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97212822
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96589910
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96588756
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96585594
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -27,6 +27,21 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96473964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96473423
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r96473148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveExplainSuite.scala
---
@@ -27,6 +27,21 @@ import
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/16594
[SPARK-17078] [SQL] Show stats when explain
## What changes were proposed in this pull request?
Currently we can only check the estimated stats in logical plans by
debugging. We need to
30 matches
Mail list logo
