Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99628216
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -39,22 +37,76 @@ private[csv] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99583376
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99583374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -39,22 +37,76 @@ private[csv] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99583137
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -170,32 +111,21 @@ class CSVFileFormat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530531
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530062
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -39,22 +37,76 @@ private[csv] object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r99530031
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -170,32 +111,21 @@ class CSVFileFormat
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r97321669
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -1,69 +0,0 @@
-/*
--- End diff --
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r97321590
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -215,32 +267,3 @@ private[csv] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r97321455
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -170,32 +111,21 @@ class CSVFileFormat
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r97321283
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -60,64 +57,9 @@ class CSVFileFormat extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16680#discussion_r97321103
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
---
@@ -0,0 +1,116 @@
+/*
--- End diff --
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/16680
[SPARK-16101][SQL] Refactoring CSV schema inference path to be consistent
with JSON
## What changes were proposed in this pull request?
This PR refactors CSV schema inference path to
14 matches
Mail list logo
