Github user XXXShao commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r137897201
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1002,9 +1018,9 @@ private[spark] object RandomForest extends
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101532020
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101531848
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101449037
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101448976
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -82,16 +92,16 @@ private[spark] object BaggedPoint {
val
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101448658
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101448626
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala
---
@@ -115,7 +122,10 @@ private[spark] object DecisionTreeMetadata
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101354732
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101351063
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -82,16 +92,16 @@ private[spark] object BaggedPoint {
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101349655
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101346522
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101342791
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101342186
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala
---
@@ -115,7 +122,10 @@ private[spark] object
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101341596
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101339952
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -99,16 +105,31 @@ class DecisionTreeRegressor
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101339732
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -126,20 +127,20 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101339648
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
---
@@ -126,20 +127,22 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101338837
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -106,14 +122,18 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101338639
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala ---
@@ -124,8 +129,8 @@ private[ml] object TreeTests extends
19 matches
Mail list logo
