Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/16733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99273860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -29,7 +29,12 @@ private case object OracleDialect extends JdbcDialect {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99273809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -29,7 +29,12 @@ private case object OracleDialect extends JdbcDiale
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99261637
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -29,7 +29,12 @@ private case object OracleDialect extends JdbcDialect {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99255047
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -726,11 +726,14 @@ class JDBCSuite extends SparkFunSuite
test(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99255011
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -29,7 +29,12 @@ private case object OracleDialect extends JdbcDialect {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16733#discussion_r99202768
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -726,11 +726,14 @@ class JDBCSuite extends SparkFunSuite
t
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/16733
[SPARK-19392][SQL] Fix the bug that throws an exception when using numeric
types in Oracle JDBC
## What changes were proposed in this pull request?
In OracleDialect, if you use Numeric types in
