GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/16753
[SPARK-19296][SQL] Deduplicate arguments in JdbcUtils.saveTable
## What changes were proposed in this pull request?
This PR deduplicates arguments, `url` and `table` in `JdbcUtils`.
```diff
def saveTable(
df: DataFrame,
- url: String,
- table: String,
tableSchema: Option[StructType],
isCaseSensitive: Boolean,
options: JDBCOptions): Unit = {
+ val url = options.url
+ val table = options.table
```
This seems only called in `JdbcRelationProvider` where both `url` and
`table `are originated from `JDBCOptions`.
## How was this patch tested?
Running unit test in `JdbcSuite`/`JDBCWriteSuite`
Building with Scala 2.10 as below:
```
./dev/change-scala-version.sh 2.10
./build/mvn -Pyarn -Phadoop-2.4 -Dscala-2.10 -DskipTests clean package
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-19296
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16753
----
commit 9be8f84756fb7e5d2a4fe31c08603688edaf998c
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2017-01-31T08:09:14Z
Deduplicate arguments in JdbcUtils.saveTable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
